apurtell commented on a change in pull request #781: HBASE-18095:
Zookeeper-less client connection implementation
URL: https://github.com/apache/hbase/pull/781#discussion_r342195724
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/client/AsyncConnectionImpl.java
##########
@@ -394,4 +394,7 @@ public Hbck getHbck(ServerName masterServer) throws
IOException {
Optional<MetricsConnection> getConnectionMetrics() {
return metrics;
}
+
+ @VisibleForTesting
+ AsyncRegistry getRegistry() { return registry; }
Review comment:
Hmm. Fine for master and branch-2, but note a headache here for branch-1 (if
a backport is desired). The precursor implementation in branch-1 is
ClusterRegistry. AsyncRegistry was a big refactor via HBASE-16835. Not
suggesting this needs be different, and some simple substitutions may get you
most of the way there, but you may want to look at this.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
