gjacoby126 commented on issue #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#issuecomment-550159469 The checkstyle bugs are trivial and I'll fix them, but I have some questions about the test failure. TestHBlock.testBlockHeapSize seems to be failing because the extra fields on the HFileContext are changing the estimate of the class heap size. Are the HFileContexts actually being serialized into the HFile? (If so, it's of course an inappropriate place to store CF / Table metadata). I don't see any place where the HFileContext is being serialized into the HFile, but if not then I'm confused why we're asserting on an exact heap footprint of a purely in-memory class, which would be really brittle. Is this test, TestHBlock.testBlockHeapSize needed? @apurtell @saintstack
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
