openinx commented on a change in pull request #796: HBASE-23251 - Add Column
Family and Table Names to HFileContext and u…
URL: https://github.com/apache/hbase/pull/796#discussion_r343961431
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##########
@@ -1267,6 +1267,8 @@ HFileBlock getBlockForCaching(CacheConfig cacheConf) {
.withCompressTags(fileContext.isCompressTags())
.withIncludesMvcc(fileContext.isIncludesMvcc())
.withIncludesTags(fileContext.isIncludesTags())
+
.withColumnFamily(fileContext.getColumnFamily())
+ .withTableName(fileContext.getTableName())
Review comment:
I see some other paths , which would also use the HFileContextBuilder to
build a new HFileContext, should we also attach the cf & tableName in it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
