brfrn169 commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N 
heavy hitter user and client drill downs
URL: https://github.com/apache/hbase/pull/722#discussion_r344092874
 
 

 ##########
 File path: 
hbase-hbtop/src/main/java/org/apache/hadoop/hbase/hbtop/screen/top/TopScreenModel.java
 ##########
 @@ -155,11 +158,13 @@ public boolean addFilter(String filterString, boolean 
ignoreCase) {
     }
 
     filters.add(filter);
+    decomposePushDownFilter();
 
 Review comment:
   It looks like it's causing a strange behavior as `pushDownFilters` will be 
cleared when adding a filter. I think we should remove to call 
decomposePushDownFilter() here.
   
   Also, can you please show `pushDownFilters` in addition to normal filters in 
`FilterDisplayModeScreenView.showFilters()` so that users can see if 
pushDownFilters is set or not?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to