[ https://issues.apache.org/jira/browse/HBASE-18439?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16970623#comment-16970623 ]
Hudson commented on HBASE-18439: -------------------------------- SUCCESS: Integrated in Jenkins build HBase-1.3-IT #671 (See [https://builds.apache.org/job/HBase-1.3-IT/671/]) HBASE-18439 Subclasses of o.a.h.h.chaos.actions.Action all use the same (jan.hentschel: rev f7ca22fd4890a952fcf8fa66254fe08567bf2306) * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomRsAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitRandomRegionOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceRegionsAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeSplitPolicyAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RollingBatchRestartRsAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeBloomFilterAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingMetaAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomZKNodeAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeEncodingAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/AddColumnAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SplitAllRegionOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MergeRandomAdjacentRegionsOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRegionsOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/Action.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ForceBalancerAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/BatchRestartRsAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/MoveRandomRegionOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/SnapshotTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/TruncateTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RemoveColumnAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActionBaseAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRandomDataNodeAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushRandomRegionOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CompactRandomRegionOfTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/FlushTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartRsHoldingTableAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/RestartActiveMasterAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/UnbalanceKillAndRebalanceAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeVersionsAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/ChangeCompressionAction.java * (edit) hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/DumpClusterStatusAction.java > Subclasses of o.a.h.h.chaos.actions.Action all use the same logger > ------------------------------------------------------------------ > > Key: HBASE-18439 > URL: https://issues.apache.org/jira/browse/HBASE-18439 > Project: HBase > Issue Type: Bug > Components: integration tests > Reporter: Mike Drob > Assignee: Rabi Kumar K C > Priority: Minor > Labels: beginner > Fix For: 3.0.0, 2.3.0, 1.6.0, 1.4.12, 1.3.7, 2.1.8, 2.2.3 > > > A bunch of the actions all use the same logger inherited from the super > class. We should have them declare distinct loggers, either each one in class > or perhaps we can do something dynamically like > {{LogFactory.getLogger(MethodHandles.lookup().lookupClass()}} and drop the > static modifier on the log field. > I'm not sure that exact incantation would actually work, but the > MethodHandles approach in general is how logger resolution happens in Solr > and it actually works out pretty well. -- This message was sent by Atlassian Jira (v8.3.4#803005)