guangxuCheng commented on a change in pull request #811: HBASE-20395 Displaying
thrift server type on the thrift page
URL: https://github.com/apache/hbase/pull/811#discussion_r344486290
##########
File path:
hbase-thrift/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
##########
@@ -871,4 +878,32 @@ private void closeScanner(
handler.scannerGet(scannerId);
handler.scannerClose(scannerId);
}
+
+ @Test
+ public void testGetThriftServerType() throws Exception {
Review comment:
Util doesn't seem to start the thriftserver. We need to test that thrift
server can return the correct server type, so we started a thriftserver as in
other unit tests of thrift.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
