infraio commented on a change in pull request #813: HBASE-23253 Rewrite rsgroup
related UTs with the new methods introduc…
URL: https://github.com/apache/hbase/pull/813#discussion_r346084072
##########
File path:
hbase-it/src/test/java/org/apache/hadoop/hbase/rsgroup/IntegrationTestRSGroup.java
##########
@@ -41,24 +41,23 @@
@Before
public void beforeMethod() throws Exception {
- if(!initialized) {
+ if (!initialized) {
LOG.info("Setting up IntegrationTestRSGroup");
LOG.info("Initializing cluster with " + NUM_SLAVES_BASE + " servers");
TEST_UTIL = new IntegrationTestingUtility();
TEST_UTIL.getConfiguration().set(HConstants.HBASE_MASTER_LOADBALANCER_CLASS,
RSGroupBasedLoadBalancer.class.getName());
TEST_UTIL.getConfiguration().set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY,
RSGroupAdminEndpoint.class.getName());
-
((IntegrationTestingUtility)TEST_UTIL).initializeCluster(NUM_SLAVES_BASE);
- //set shared configs
- admin = TEST_UTIL.getAdmin();
- cluster = TEST_UTIL.getHBaseClusterInterface();
- rsGroupAdmin = new VerifyingRSGroupAdminClient(new
RSGroupAdminClient(TEST_UTIL.getConnection()),
- TEST_UTIL.getConfiguration());
+ ((IntegrationTestingUtility)
TEST_UTIL).initializeCluster(NUM_SLAVES_BASE);
+ // set shared configs
+ ADMIN = TEST_UTIL.getAdmin();
+ CLUSTER = TEST_UTIL.getHBaseClusterInterface();
+ RS_GROUP_ADMIN_CLIENT = new
RSGroupAdminClient(TEST_UTIL.getConnection());
Review comment:
Still need RS_GROUP_ADMIN_CLIENT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
