Apache9 commented on a change in pull request #813: HBASE-23253 Rewrite rsgroup
related UTs with the new methods introduc…
URL: https://github.com/apache/hbase/pull/813#discussion_r346097080
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -2860,6 +2866,94 @@ private boolean shouldSubmitSCP(ServerName serverName) {
return true;
}
+ @Override
+ public GetRSGroupInfoResponse getRSGroupInfo(RpcController controller,
+ GetRSGroupInfoRequest request) throws ServiceException {
+ String groupName = request.getRSGroupName();
+ LOG.info(
+ master.getClientIdAuditPrefix() + " initiates rsgroup info retrieval,
group=" + groupName);
+ try {
+ if (master.getMasterCoprocessorHost() != null) {
+ master.getMasterCoprocessorHost().preGetRSGroupInfo(groupName);
+ }
+ RSGroupInfo rsGroupInfo =
master.getRSGroupInfoManager().getRSGroup(groupName);
+ GetRSGroupInfoResponse resp;
+ if (rsGroupInfo != null) {
+ resp = GetRSGroupInfoResponse.newBuilder()
+ .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
+ } else {
+ resp = GetRSGroupInfoResponse.getDefaultInstance();
+ }
+ if (master.getMasterCoprocessorHost() != null) {
+ master.getMasterCoprocessorHost().postGetRSGroupInfo(groupName);
+ }
+ return resp;
+ } catch (IOException e) {
+ throw new ServiceException(e);
+ }
+ }
+
+ @Override
+ public GetRSGroupInfoOfTableResponse getRSGroupInfoOfTable(RpcController
controller,
+ GetRSGroupInfoOfTableRequest request) throws ServiceException {
+ TableName tableName = ProtobufUtil.toTableName(request.getTableName());
+ LOG.info(
+ master.getClientIdAuditPrefix() + " initiates rsgroup info retrieval,
table=" + tableName);
+ try {
+ if (master.getMasterCoprocessorHost() != null) {
+ master.getMasterCoprocessorHost().preGetRSGroupInfoOfTable(tableName);
+ }
+ GetRSGroupInfoOfTableResponse resp;
+ TableDescriptor td = master.getTableDescriptors().get(tableName);
+ if (td == null) {
+ resp = GetRSGroupInfoOfTableResponse.getDefaultInstance();
+ } else {
+ RSGroupInfo rsGroupInfo = null;
+ if (td.getRegionServerGroup().isPresent()) {
+ rsGroupInfo =
master.getRSGroupInfoManager().getRSGroup(td.getRegionServerGroup().get());
+ }
+ if (rsGroupInfo == null) {
+ rsGroupInfo =
master.getRSGroupInfoManager().getRSGroup(RSGroupInfo.DEFAULT_GROUP);
+ }
+ resp = GetRSGroupInfoOfTableResponse.newBuilder()
+ .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
+ }
+ if (master.getMasterCoprocessorHost() != null) {
+ master.getMasterCoprocessorHost().postGetRSGroupInfoOfTable(tableName);
+ }
+ return resp;
+ } catch (IOException e) {
+ throw new ServiceException(e);
+ }
+ }
+
+ @Override
+ public GetRSGroupInfoOfServerResponse getRSGroupInfoOfServer(RpcController
controller,
+ GetRSGroupInfoOfServerRequest request) throws ServiceException {
+ Address hp =
+ Address.fromParts(request.getServer().getHostName(),
request.getServer().getPort());
+ LOG.info(master.getClientIdAuditPrefix() + " initiates rsgroup info
retrieval, server=" + hp);
+ try {
+ if (master.getMasterCoprocessorHost() != null) {
+ master.getMasterCoprocessorHost().preGetRSGroupInfoOfServer(hp);
+ }
+ RSGroupInfo rsGroupInfo =
master.getRSGroupInfoManager().getRSGroupOfServer(hp);
+ GetRSGroupInfoOfServerResponse resp;
+ if (rsGroupInfo != null) {
+ resp = GetRSGroupInfoOfServerResponse.newBuilder()
+ .setRSGroupInfo(ProtobufUtil.toProtoGroupInfo(rsGroupInfo)).build();
+ } else {
+ resp = GetRSGroupInfoOfServerResponse.getDefaultInstance();
Review comment:
I think here we do not care whether the server is online or not? Just means
there is no group which contains this server.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
