Apache9 commented on a change in pull request #820: HBASE-23286 Improve MTTR:
Split WAL to HFile
URL: https://github.com/apache/hbase/pull/820#discussion_r346339041
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java
##########
@@ -61,13 +61,13 @@
* Class that manages the output streams from the log splitting process.
*/
@InterfaceAudience.Private
-public class LogRecoveredEditsOutputSink extends OutputSink {
- private static final Logger LOG =
LoggerFactory.getLogger(LogRecoveredEditsOutputSink.class);
- private WALSplitter walSplitter;
- private FileSystem walFS;
- private Configuration conf;
+public class RecoveredEditsOutputSink extends OutputSink {
+ private static final Logger LOG =
LoggerFactory.getLogger(RecoveredEditsOutputSink.class);
+ protected WALSplitter walSplitter;
+ protected FileSystem walFS;
Review comment:
And I believe this will introduce problems. Think of HBase on S3, where we
will still write WAL to HDFS, but HFile will be on S3. So for writing HFiles we
should use the HFile FileSystem instead of WAL FileSystem.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
