guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] 
build RegionPlan per group not per table
URL: https://github.com/apache/hbase/pull/831#discussion_r346850295
 
 

 ##########
 File path: 
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
 ##########
 @@ -607,6 +613,22 @@ public void removeServers(Set<Address> servers) throws 
IOException {
     return result;
   }
 
+  private Map<ServerName, List<RegionInfo>> getAssignmentsByGroup(String 
groupName)
 
 Review comment:
   mis-placed regions will not be moved to the group.
   We should get the grouping information through the tables in the group 
instead of the servers

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to