bharathv commented on a change in pull request #807: HBASE-23259: Ability to 
start minicluster with pre-determined master ports
URL: https://github.com/apache/hbase/pull/807#discussion_r347070047
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/LocalHBaseCluster.java
 ##########
 @@ -173,6 +173,14 @@ public LocalHBaseCluster(final Configuration conf, final 
int noMasters,
     for (int i = 0; i < noMasters; i++) {
       addMaster(new Configuration(conf), i);
     }
+
+    // Populate the master address host ports in the config. This is needed if 
a master based
+    // registry is configured for client metadata services (HBASE-18095)
+    List<String> masterHostPorts = new ArrayList<>();
+    getMasters().forEach(masterThread ->
 
 Review comment:
   Thanks for the heads up.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to