[GitHub] [hbase] sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to ChainWalEntryFilter to filter the whole entry if all cells get filtered

[GitBox]

sandeepvinayak commented on issue #837: HBASE-23309: Adding the flexibility to 
ChainWalEntryFilter to filter the whole entry if all cells get filtered
URL: https://github.com/apache/hbase/pull/837#issuecomment-554821242
 
 
   For example 
[getWALEntryfilter](https://github.com/Apache9/hbase/blob/master/hbase-server/src/main/java/org/apache/hadoop/hbase/replication/BaseReplicationEndpoint.java#L70)
 in BaseReplicationEndpoint can set this flag if it needs to by the following:
   
   ```java
   if !filters.isEmpty() {
       ChainWALEntryFilter chainFilter = new ChainWALEntryFilter(filters);
       chainFilter.setFilterEmptyEntry(true);
       return chainFilter;
   }
   ```
   instead of 
   ```
   return filters.isEmpty() ? null : new ChainWALEntryFilter(filters);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services