bharathv commented on issue #846: HBASE-23234 Provide .editorconfig based on checkstyle configuration URL: https://github.com/apache/hbase/pull/846#issuecomment-555225451 Sean beat me to it. Looks like he put the same comment. I'm an intellij user but just out of curiosity I tried eclipse to see how the whole checkstyle thing works. Following are my observations fwiw. 1. I tried eclipse-cs [1]. It fails with the following error which apparently is a known problem https://github.com/checkstyle/eclipse-cs/issues/107. Couldn't workaround it. java.lang.NoClassDefFoundError: org/eclipse/jdt/internal/ui/preferences/PreferencesAccess at net.sf.eclipsecs.core.transformer.FormatterConfigWriter.writeCleanupSettings(FormatterConfigWriter.java:95) at net.sf.eclipsecs.core.transformer.FormatterConfigWriter.writeSettings(FormatterConfigWriter.java:89) at net.sf.eclipsecs.core.transformer.FormatterConfigWriter.<init>(FormatterConfigWriter.java:81) at net.sf.eclipsecs.core.transformer.CheckstyleTransformer.transformRules(CheckstyleTransformer.java:124) at net.sf.eclipsecs.core.jobs.TransformCheckstyleRulesJob.runInWorkspace(TransformCheckstyleRulesJob.java:119) at org.eclipse.core.internal.resources.InternalWorkspaceJob.run(InternalWorkspaceJob.java:42) at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63) 2. This patch's editorconfig file doesn't work with my eclipse setup for whatever reason. I'm not able to figure out why. [1] https://stackoverflow.com/questions/984778/how-to-generate-an-eclipse-formatter-configuration-from-a-checkstyle-configurati
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
