apurtell commented on a change in pull request #837: HBASE-23309: Adding the
flexibility to ChainWalEntryFilter to filter the whole entry if all cells get
filtered
URL: https://github.com/apache/hbase/pull/837#discussion_r347682215
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/replication/ChainWALEntryFilter.java
##########
@@ -68,13 +82,17 @@ public void initCellFilters() {
@Override
public Entry filter(Entry entry) {
+
for (WALEntryFilter filter : filters) {
if (entry == null) {
return null;
}
entry = filter.filter(entry);
}
filterCells(entry);
+ if (shouldFilterEmptyEntry() && entry != null &&
entry.getEdit().isEmpty()) {
Review comment:
Put this into your own WALEntryFilter. Or, fine if you want to add a
WALEntryFilter impl to HBase code that does this. But don't do this here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
