joshelser commented on a change in pull request #834: HBASE-23237 Negative sign in requestsPerSecond URL: https://github.com/apache/hbase/pull/834#discussion_r348124897
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java ########## @@ -115,6 +118,8 @@ private volatile long mobFileCacheCount = 0; private volatile long blockedRequestsCount = 0L; private volatile long averageRegionSize = 0L; + protected volatile Map<String, ArrayList<Long>> requestsCountCache = new Review comment: You're not changing the object that `requestsCountCache` points to, are you? I think you can drop `volatile` and make this `final`. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
