[
https://issues.apache.org/jira/browse/HBASE-5653?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250654#comment-13250654
]
Jonathan Hsieh commented on HBASE-5653:
---------------------------------------
Looks good to me. One suggestion:
{code}
totalReplicated++;
}
- for(byte [] table : rows.keySet()) {
- batch(table, rows.get(table));
+ for (Iterator<Entry<byte[], List<Row>>> iterator = rows.entrySet()
+ .iterator(); iterator.hasNext();) {
+ Entry<byte[], List<Row>> keyValues = iterator.next();
+ batch(keyValues.getKey(), keyValues.getValue());
}
{code}
Maybe write this way instead:
{code}
for (Entry<byte[], List<Row>> entry : rows.entrySet()) {
batch(entry.getKey(), entry.getValue());
}
{code}
> [findbugs] fix perf warnings
> ----------------------------
>
> Key: HBASE-5653
> URL: https://issues.apache.org/jira/browse/HBASE-5653
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: Uma Maheswara Rao G
> Attachments: HBASE-5653.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html#Warnings_PERFORMANCE
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
