[
https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16979702#comment-16979702
]
Sandeep Pal commented on HBASE-23309:
-------------------------------------
No it’s not a bug as far as I can see. It’s just a flexibility to the custom
wal filter if they won’t want the empty entries to go through, Custom WAL
Filter may choose this flexibility because they are "custom" :) . I see this
because I am writing a filter implementing both filter and cellFilter and I see
the entries getting filtered even though all cells are filtered. Some other
filters may also have scenario where they don’t want to let the empty entries
go through.
> Add support in ChainWalEntryFilter to filter Entry if all cells get filtered
> through WalCellFilter
> --------------------------------------------------------------------------------------------------
>
> Key: HBASE-23309
> URL: https://issues.apache.org/jira/browse/HBASE-23309
> Project: HBase
> Issue Type: Improvement
> Affects Versions: 3.0.0, 1.3.6, 2.3.3
> Reporter: Sandeep Pal
> Assignee: Sandeep Pal
> Priority: Major
> Attachments: HBASE-23309.branch-1.patch, HBASE-23309.branch-2.patch,
> HBASE-23309.patch
>
>
> ChainWalEntryFilter applies the filter on entry followed by filter on cells.
> If filter on cells remove all the cells from the entry, we should add an
> option in chainwalentryfilter to filter the entry as well.
> Here is the snippet for ChainWalEntryFilter filter. After filterCells we
> should check if there is any cells remaining in the entry.
> {code:java}
> @Override
> public Entry filter(Entry entry) {
> for (WALEntryFilter filter : filters) {
> if (entry == null) {
> return null;
> }
> entry = filter.filter(entry);
> }
> filterCells(entry);
> return entry;
> }{code}
> Customer replication endpoints may use this flag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
