joshelser commented on a change in pull request #850: HBASE-23312 HBase Thrift 
SPNEGO configs (HBASE-19852) should be backwards compatible
URL: https://github.com/apache/hbase/pull/850#discussion_r350389988
 
 

 ##########
 File path: 
hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServer.java
 ##########
 @@ -249,6 +263,27 @@ protected void setupParamters() throws IOException {
     pauseMonitor.start();
   }
 
+  private String getSpengoPrincipal(Configuration conf, String host) throws 
IOException {
+    String principal = conf.get(THRIFT_SPNEGO_PRINCIPAL_KEY);
 
 Review comment:
   Given I missed this the first time, the comment clearly explains things to 
me. Resolving.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to