xcangCRM commented on a change in pull request #856: HBASE-21776: Duplicate 
"Set storagePolicy" debug logging
URL: https://github.com/apache/hbase/pull/856#discussion_r350535546
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
 ##########
 @@ -189,8 +189,14 @@ Path createStoreDir(final String familyName) throws 
IOException {
    * @param familyName The name of column family.
    * @param policyName The name of the storage policy
    */
-  public void setStoragePolicy(String familyName, String policyName) {
-    FSUtils.setStoragePolicy(this.fs, getStoreDir(familyName), policyName);
+  public void setStoragePolicy(String familyName, String policyName) throws 
IOException {
+    if (this.fs instanceof HFileSystem) {
 
 Review comment:
   could you please explain why handling HFileSystem separately here?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to