liuml07 commented on issue #864: HBASE-23313 [hbck2] setRegionState should update Master in-memory sta… URL: https://github.com/apache/hbase/pull/864#issuecomment-558517478 This patch looks good to me overall. I agree this would be more practical and useful to support list of region states. I still think if we want to make the request/response a little bit concise, the `{RegionSpecifier, RegionState.State}` pair would be better than the `RegionState` in both request and/or response. RegionInfo fields and timestamp are not all used in Master side, and passing them over RPC request/response seems not necessary. Honestly I have not checked the HBCK2 side (the code would be minimum I imagine) where they may find those RegionState more meaningful?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
