saintstack commented on a change in pull request #832: HBASE-23298 Refactor LogRecoveredEditsOutputSink and BoundedLogWriter… URL: https://github.com/apache/hbase/pull/832#discussion_r350893556
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/RecoveredEditsOutputSink.java ########## @@ -0,0 +1,154 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.wal; + +import java.io.IOException; +import java.io.InterruptedIOException; +import java.util.List; +import java.util.Map; +import java.util.TreeMap; +import java.util.concurrent.ConcurrentHashMap; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.Future; + +import org.apache.hadoop.fs.Path; +import org.apache.hadoop.hbase.TableName; +import org.apache.hadoop.hbase.util.Bytes; +import org.apache.hadoop.io.MultipleIOException; +import org.apache.yetus.audience.InterfaceAudience; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import org.apache.hbase.thirdparty.com.google.common.collect.Lists; + +/** + * Class that manages the output streams from the log splitting process. + * Every region only has one recovered edits. + */ [email protected] +public class RecoveredEditsOutputSink extends AbstractRecoveredEditsOutputSink { + private static final Logger LOG = LoggerFactory.getLogger(RecoveredEditsOutputSink.class); + private ConcurrentHashMap<String, RecoveredEditsWriter> writers = new ConcurrentHashMap<>(); + + public RecoveredEditsOutputSink(WALSplitter walSplitter, + WALSplitter.PipelineController controller, EntryBuffers entryBuffers, int numWriters) { + super(walSplitter, controller, entryBuffers, numWriters); + } + + @Override + public void append(EntryBuffers.RegionEntryBuffer buffer) throws IOException { + List<WAL.Entry> entries = buffer.entryBuffer; + if (entries.isEmpty()) { + LOG.warn("got an empty buffer, skipping"); + return; + } + RecoveredEditsWriter writer = getWriter(buffer.tableName, buffer.encodedRegionName, + entries.get(0).getKey().getSequenceId()); + if (writer != null) { + writer.writeRegionEntries(entries); + } + } + + /** + * Get a writer and path for a log starting at the given entry. This function is threadsafe so + * long as multiple threads are always acting on different regions. + * @return null if this region shouldn't output any logs + */ + private RecoveredEditsWriter getWriter(TableName tableName, byte[] region, long seqId) Review comment: Yeah, getRecoveredEditsWriter? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
