sandeepvinayak commented on a change in pull request #856: HBASE-21776:
Duplicate "Set storagePolicy" debug logging
URL: https://github.com/apache/hbase/pull/856#discussion_r350935706
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java
##########
@@ -189,8 +189,14 @@ Path createStoreDir(final String familyName) throws
IOException {
* @param familyName The name of column family.
* @param policyName The name of the storage policy
*/
- public void setStoragePolicy(String familyName, String policyName) {
- FSUtils.setStoragePolicy(this.fs, getStoreDir(familyName), policyName);
+ public void setStoragePolicy(String familyName, String policyName) throws
IOException {
+ if (this.fs instanceof HFileSystem) {
Review comment:
@wchevreuil We do the similar thing at several places in this file, it's
not just the duplicate traces but to avoid the duplicate useless function
calls. I believe title of the jira should be modified.
Here is an example where we get the backing file system is case it is
instance of hfilesystem
https://github.com/apache/hbase/blob/branch-1/hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionFileSystem.java#L535
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
