bharathv commented on a change in pull request #872: HBASE-23333 Provide call
context around timeouts and other failure scenarios
URL: https://github.com/apache/hbase/pull/872#discussion_r351426984
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/BlockingRpcConnection.java
##########
@@ -194,7 +194,7 @@ public void run() {
// exception here means the call has not been added to the
pendingCalls yet, so we need
// to fail it by our own.
if (LOG.isDebugEnabled()) {
- LOG.debug("call write error for call #" + call.id, e);
+ LOG.debug("call write error for " + call, e);
Review comment:
nit: use parameterized logging and skip the if check?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
