Apache9 commented on a change in pull request #832: HBASE-23298 Refactor
LogRecoveredEditsOutputSink and BoundedLogWriter…
URL: https://github.com/apache/hbase/pull/832#discussion_r351612992
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -41,39 +42,36 @@
* ways of consuming recovered edits.
*/
@InterfaceAudience.Private
-public abstract class OutputSink {
+abstract class OutputSink {
private static final Logger LOG = LoggerFactory.getLogger(OutputSink.class);
- protected WALSplitter.PipelineController controller;
+ private WALSplitter.PipelineController controller;
protected EntryBuffers entryBuffers;
- protected ConcurrentHashMap<String, WALSplitter.SinkWriter> writers = new
ConcurrentHashMap<>();
- protected final ConcurrentHashMap<String, Long> regionMaximumEditLogSeqNum =
- new ConcurrentHashMap<>();
-
- protected final List<WriterThread> writerThreads = Lists.newArrayList();
-
- /* Set of regions which we've decided should not output edits */
- protected final Set<byte[]> blacklistedRegions =
- Collections.synchronizedSet(new TreeSet<>(Bytes.BYTES_COMPARATOR));
-
- protected boolean closeAndCleanCompleted = false;
-
- protected boolean writersClosed = false;
+ private final List<WriterThread> writerThreads = Lists.newArrayList();
protected final int numThreads;
protected CancelableProgressable reporter = null;
- protected AtomicLong skippedEdits = new AtomicLong();
+ protected AtomicLong totalSkippedEdits = new AtomicLong();
Review comment:
Ditto.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
