wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable
custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r351846068
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/ipc/RpcConnection.java
##########
@@ -118,70 +118,22 @@ protected RpcConnection(Configuration conf,
HashedWheelTimer timeoutTimer, Conne
LOG.debug("RPC Server Kerberos principal name for service=" +
remoteId.getServiceName()
+ " is " + serverPrincipal);
}
- }
- this.token = token;
- this.serverPrincipal = serverPrincipal;
- if (!useSasl) {
- authMethod = AuthMethod.SIMPLE;
- } else if (token != null) {
- authMethod = AuthMethod.DIGEST;
+ } else if (!useSasl) {
+ // Hack, while SIMPLE doesn't go via SASL.
+ provider = providers.getSimpleProvider();
+ this.token = null;
Review comment:
Maybe move this to SaslClientAuthenticationProvider.selectProvider, so that
if useSasl is false, it returns a SimpleProvider and null token?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
