wchevreuil commented on a change in pull request #884: HBASE-23347 Allowable
custom authentication methods for RPCs
URL: https://github.com/apache/hbase/pull/884#discussion_r351857029
##########
File path:
hbase-client/src/main/java/org/apache/hadoop/hbase/security/AbstractHBaseSaslRpcClient.java
##########
@@ -65,9 +56,10 @@
* @param fallbackAllowed does the client allow fallback to simple
authentication
* @throws IOException
*/
- protected AbstractHBaseSaslRpcClient(AuthMethod method, Token<? extends
TokenIdentifier> token,
+ protected AbstractHBaseSaslRpcClient(Configuration conf,
SaslClientAuthenticationProvider provider,
+ Token<? extends TokenIdentifier> token,
String serverPrincipal, boolean fallbackAllowed) throws IOException {
- this(method, token, serverPrincipal, fallbackAllowed, "authentication");
+ this(conf, provider, token, serverPrincipal, fallbackAllowed,
"authentication");
Review comment:
nit: update javadoc params description.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
