[
https://issues.apache.org/jira/browse/HBASE-23337?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985246#comment-16985246
]
Sean Busbey commented on HBASE-23337:
-------------------------------------
bq. Could you please create a PR for this patch?
sure. I found an error I need to fix first.
bq. On the gpg part, it works for me in the past, not sure why it does not work
for you...
The failure mode is just prompting me an extra time for the password I already
gave it. If I were around to notice it I think the rest would go fine. AFAICT
it's not related to this change, so I'm happy to deal with it elsewhere.
{quote}
bq. Click close manually on https://repository.apache.org/ is not a big deal...
Just to note that main value of this script is end-to-end RM'ing. If it don't
do that, it won't get used.
{quote}
Please note that this isn't an issue with the current patch. It successfully
closes the staging repo and presents the staged repo name to the RM.
bq. If the gpg agent thing ain't working, suggest putting in a comment inline
into the script so next person along doesn't think it is something they are
doing wrong..... ?
Like where though? AFAICT the gpg agent handling isn't working correctly on my
box with our without this change. If no one else has noticed an issue I'd
rather not confuse things with a warning.
{quote}
Hard to tell... is this section right... We replacing the popd+rm-rf w/ a '}'.
May be just formatting.
{code}
300
301 popd
302 rm -rf "$tmp_repo"
303 cd ..
237 )
{code}
{quote}
yeah I switched to a subshell so that I didn't have to worry about changing out
of the project directory. for example, the current code leaves you dropped in
the project directory when something goes wrong. Let me make sure the temp repo
clean up still happens.
(as an aside, this was the cause of a problem with the current patch because
the name of the repo is scoped to just inside the subshell, so it is blank in
the email that gets generated. but I'll fix that shortly.)
bq. The remove of the GPG define in release-build.sh is because it not needed
anymore now using mvn plugin?
yes. originally I didn't muck with it but shellcheck called me out for having
an unused variable.
> Several modules missing in nexus for Apache HBase 2.2.2
> -------------------------------------------------------
>
> Key: HBASE-23337
> URL: https://issues.apache.org/jira/browse/HBASE-23337
> Project: HBase
> Issue Type: Bug
> Components: build, community, scripts
> Affects Versions: 2.2.2
> Reporter: Chao
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 3.0.0
>
> Attachments: HBASE-23337.0.patch, HBASE-23337.1.patch
>
>
> The latest version of hbase-shaded-client is currently 2.2.1. It has been a
> while since 2.2.2 release (2019/10/25). See:
> [https://search.maven.org/search?q=hbase-shaded-client].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
