[ https://issues.apache.org/jira/browse/HBASE-23345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16988334#comment-16988334 ]
Hudson commented on HBASE-23345: -------------------------------- Results for branch branch-2.2 [build #713 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/713/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/713//General_Nightly_Build_Report/] (x) {color:red}-1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/713//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 jdk8 hadoop3 checks{color} -- For more information [see jdk8 (hadoop3) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-2.2/713//JDK8_Nightly_Build_Report_(Hadoop3)/] (/) {color:green}+1 source release artifact{color} -- See build output for details. (/) {color:green}+1 client integration test{color} > Table need to replication unless all of cfs are excluded > -------------------------------------------------------- > > Key: HBASE-23345 > URL: https://issues.apache.org/jira/browse/HBASE-23345 > Project: HBase > Issue Type: Bug > Components: Replication > Reporter: Sun Xin > Assignee: Sun Xin > Priority: Minor > Fix For: 3.0.0, 2.3.0, 2.2.3, 2.1.9 > > Attachments: HBASE-23345.branch-2.001.patch, > HBASE-23345.branch-2.002.patch, HBASE-23345.branch-2.002.patch > > > There is duplicate code in ReplicationUtils.contains and > ReplicationPeerConfig.needToReplicate about deciding whether a table need > replicate to the peer cluster. > And the implementation of ReplicationPeerConfig.needToReplicate has a bug, it > return false when replicateAllUserTables flag is true and excludeTableCFsMap > contains not all of cfs. > > We should copy the code from ReplicationUtils.contains to > ReplicationPeerConfig.needToReplicate, and delete > ReplicationUtils.contains.Because ReplicationUtils is from module > replication, ReplicationPeerConfig is from module client, and module > replication depends on module client. > > In the following code, ReplicationPeerConfig.needToReplicate return false, > when replicateAllUserTables flag is true and excludeTableCFsMap contains not > all of cfs. > {code:java} > public boolean needToReplicate(TableName table) { > if (replicateAllUserTables) { > ...... > if (excludeTableCFsMap != null && excludeTableCFsMap.containsKey(table)) { > return false; > } > ...... > } > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)