ndimiduk commented on a change in pull request #872: HBASE-23333 Provide call
context around timeouts and other failure scenarios
URL: https://github.com/apache/hbase/pull/872#discussion_r354596515
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/util/TestFutureUtils.java
##########
@@ -80,6 +80,8 @@ public void testRecordStackTrace() throws IOException {
startsWith("org.apache.hadoop.hbase.util.TestFutureUtils.testRecordStackTrace"));
assertTrue(Stream.of(elements)
.anyMatch(element ->
element.toString().contains("--------Future.get--------")));
+ } catch (Throwable t) {
+ throw new AssertionError("Caught unexpected Throwable", t);
Review comment:
This is to ensure that the test fails when the exception we expect isn't
thrown. It would be simply `fail()` except that api doesn't let me retain the
context provided by `t`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
