wchevreuil commented on a change in pull request #45: HBASE-23371 [HBCK2]
Provide client side method for removing ghost regions in meta.
URL:
https://github.com/apache/hbase-operator-tools/pull/45#discussion_r355122909
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -99,8 +97,10 @@
private static final String ADD_MISSING_REGIONS_IN_META_FOR_TABLES =
"addFsRegionsMissingInMeta";
- private static final String ADD_MISSING_REGIONS_IN_META =
"addMissingRegionsInMeta";
private static final String REPORT_MISSING_REGIONS_IN_META =
"reportMissingRegionsInMeta";
+ static final String REMOVE_EXTRA_REGIONS_IN_META_FROM_TABLES =
+ "removeExtraRegionsFromMeta";
+ static final String REPORT_EXTRA_REGIONS_IN_META =
"reportExtraRegionsInMeta";
Review comment:
> Unless the region is overlapped with other regions in meta, uses should
use assign '<region>' command as a viable action to take because it generates a
new empty region directory appropriately via
org.apache.hadoop.hbase.regionserver.HRegionFileSystem#writeRegionInfoFileContent.
Thanks for pointing this out, @daisukebe ! Let me add this valuable insight
to the command instructions and "recipes" section of the README.
> People in the real world, including me, are still using hbck1 as a trusted
report to deal with inconsistencies
Yeah, hbck2 is not targeted to be a reporting tool, but as part of work for
both this new command and the _addFsRegionsMissingInMeta_ is to figure out
which regions these need to fix, had then decided to expose the _checking_
logic as a reporting command that can be executed on its own.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
