[
https://issues.apache.org/jira/browse/HBASE-5645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251342#comment-13251342
]
Uma Maheswara Rao G commented on HBASE-5645:
--------------------------------------------
1) ShutdownHook.java
{code}
if (cache == null) {
throw new RuntimeException(
"This should not happen. Could not find the cache class in
FileSystem.");
}
Field field = null;
try {
field = cache.getDeclaredField(CLIENT_FINALIZER_DATA_METHOD);
} catch (NoSuchFieldException e) {
// We can get here if the Cache class does not have a clientFinalizer
// instance: i.e. we're running on straight 0.20 w/o hadoop-4829.
}
{code}
2) In Store.java
{code}
byte[] firstKey = reader.getFirstRowKey();
Preconditions.checkState(firstKey != null, "First key can not be null");
byte[] lk = reader.getLastKey();
Preconditions.checkState(lk != null, "Last key can not be null");
byte[] lastKey = KeyValue.createKeyValueFromKey(lk).getRow();
{code}
We already handled this with preconditions.
3) {code}
int logCount = this.outputfiles == null? 0: this.outputfiles.size();
+ int logCount = this.outputfiles.size();
{code}
This change also already handled by Hbase-5653. So may need to update with
latest.
Mostly all are need to resolve the conflicts with fixed and committed changes.
> [findbugs] Fix correctness warnings
> -----------------------------------
>
> Key: HBASE-5645
> URL: https://issues.apache.org/jira/browse/HBASE-5645
> Project: HBase
> Issue Type: Sub-task
> Components: scripts
> Reporter: Jonathan Hsieh
> Assignee: David S. Wang
> Attachments: HBASE-5645-2.patch, HBASE-5645.patch, HBASE-5645.patch
>
>
> See
> https://builds.apache.org/job/PreCommit-HBASE-Build/1313//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
> Fix the warnings in the correctness section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
