[
https://issues.apache.org/jira/browse/HBASE-23374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16991143#comment-16991143
]
Anoop Sam John commented on HBASE-23374:
----------------------------------------
Looks good at a glance. [~openinx] Pls have a look. I hope the remaining
flows including the cloneUncompressedBufferWithHeader/
cloneOnDiskBufferWithHeader handles the BBPool correctly. We need a revisit
for this entire flow and usage of the pool because new possible usage of pool
was added later (like HBASE-22802 )
> ExclusiveMemHFileBlock’s allocator should not be hardcoded as
> ByteBuffAllocator.HEAP
> ------------------------------------------------------------------------------------
>
> Key: HBASE-23374
> URL: https://issues.apache.org/jira/browse/HBASE-23374
> Project: HBase
> Issue Type: Improvement
> Reporter: chenxu
> Assignee: chenxu
> Priority: Minor
>
> ExclusiveMemHFileBlock's constructor looks like this:
> {code:java}
> ExclusiveMemHFileBlock(BlockType blockType, int onDiskSizeWithoutHeader,
> int uncompressedSizeWithoutHeader, long prevBlockOffset, ByteBuff buf,
> boolean fillHeader,
> long offset, int nextBlockOnDiskSize, int onDiskDataSizeWithHeader,
> HFileContext fileContext) {
> super(blockType, onDiskSizeWithoutHeader, uncompressedSizeWithoutHeader,
> prevBlockOffset, buf,
> fillHeader, offset, nextBlockOnDiskSize, onDiskDataSizeWithHeader,
> fileContext,
> ByteBuffAllocator.HEAP);
> }
> {code}
> After HBASE-22802, ExclusiveMemHFileBlock’s data may be allocated through the
> BB pool, so it’s allocator should not be hard coded as ByteBuffAllocator.HEAP
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
