saintstack commented on a change in pull request #917: HBASE-23383 [hbck2]
`fixHoles` should queue assignment procedures for any regions its fixing
URL: https://github.com/apache/hbase/pull/917#discussion_r355132830
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAssignmentManager.java
##########
@@ -171,17 +171,11 @@ public void testAssignAnAssignedRegion() throws
Exception {
// wait first assign
waitOnFuture(futureA);
am.getRegionStates().isRegionInState(hri, State.OPEN);
- // Second should be a noop. We should recognize region is already OPEN
internally
- // and skip out doing nothing.
- // wait second assign
- Future<byte[]> futureB = submitProcedure(createAssignProcedure(hri));
- waitOnFuture(futureB);
- am.getRegionStates().isRegionInState(hri, State.OPEN);
- // TODO: What else can we do to ensure just a noop.
+ assertNull(createAssignProcedure(hri));
Review comment:
Good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
