chenxu14 commented on a change in pull request #919: HBASE-23066 Allow cache on
write during compactions when prefetching is
URL: https://github.com/apache/hbase/pull/919#discussion_r355974362
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -1118,9 +1118,9 @@ public StoreFileWriter createWriterInTmp(long
maxKeyCount, Compression.Algorithm
boolean shouldDropBehind) throws IOException {
final CacheConfig writerCacheConf;
if (isCompaction) {
- // Don't cache data on write on compactions.
+ // Don't cache data on write on compactions, unless specifically
configured to do so
writerCacheConf = new CacheConfig(cacheConf);
- writerCacheConf.setCacheDataOnWrite(false);
+
writerCacheConf.setCacheDataOnWrite(cacheConf.shouldCacheCompactedBlocksOnWrite());
Review comment:
OK, looking forward to
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
