saintstack commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356336977
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileReaderImpl.java
##########
@@ -874,12 +874,10 @@ private void positionThisBlockBuffer() {
try {
blockBuffer.skip(getCurCellSerializedSize());
} catch (IllegalArgumentException e) {
- LOG.error("Current pos = " + blockBuffer.position()
- + "; currKeyLen = " + currKeyLen + "; currValLen = "
- + currValueLen + "; block limit = " + blockBuffer.limit()
- + "; currBlock currBlockOffset = " + this.curBlock.getOffset()
- + "; path=" + reader.getPath());
- throw e;
+ throw new IllegalArgumentException("Current pos = " +
blockBuffer.position()
+ + "; currKeyLen = " + currKeyLen + "; currValLen = " +
currValueLen + "; block limit = "
+ + blockBuffer.limit() + "; currBlock currBlockOffset = " +
this.curBlock.getOffset()
+ + "; path=" + reader.getPath(), e);
Review comment:
ok.
These patterns are written up? We should get them into our refguide under
developer chapter.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
