[ https://issues.apache.org/jira/browse/HBASE-5719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251683#comment-13251683 ]
jirapos...@reviews.apache.org commented on HBASE-5719: ------------------------------------------------------ ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4649/#review6851 ----------------------------------------------------------- Ship it! Looks good to me Jimmy. Mind checking 0.90/0.92/0.94 and doing ports if necessary? Should be trivial. I have one nit that you can address or ignore. :) src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java <https://reviews.apache.org/r/4649/#comment15241> nit: would be easier to read if assertTrue((r1.equals(ac) && r2.equals(ae)) || (r1.equals(ae) && r2.equals(ac))); - jmhsieh On 2012-04-09 19:27:53, Jimmy Xiang wrote: bq. bq. ----------------------------------------------------------- bq. This is an automatically generated e-mail. To reply, visit: bq. https://reviews.apache.org/r/4649/ bq. ----------------------------------------------------------- bq. bq. (Updated 2012-04-09 19:27:53) bq. bq. bq. Review request for hbase and jmhsieh. bq. bq. bq. Summary bq. ------- bq. bq. Make it configurable to sideline some regions in big overlapped groups which hbck doesn't handle currently. bq. bq. The regions chose to sideline are those which overlap with most other regions. bq. bq. bq. This addresses bug HBASE-5719. bq. https://issues.apache.org/jira/browse/HBASE-5719 bq. bq. bq. Diffs bq. ----- bq. bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 54f9b21 bq. src/main/java/org/apache/hadoop/hbase/util/RegionSplitCalculator.java 17678dd bq. src/test/java/org/apache/hadoop/hbase/util/TestRegionSplitCalculator.java ac3b225 bq. bq. Diff: https://reviews.apache.org/r/4649/diff bq. bq. bq. Testing bq. ------- bq. bq. mvn -PlocalTests -Dtest=TestHBaseFsck* clean test bq. bq. Also tested in real system to fix inconsistencies. bq. bq. bq. Thanks, bq. bq. Jimmy bq. bq. > Enhance hbck to sideline overlapped mega regions > ------------------------------------------------ > > Key: HBASE-5719 > URL: https://issues.apache.org/jira/browse/HBASE-5719 > Project: HBase > Issue Type: New Feature > Components: hbck > Affects Versions: 0.94.0, 0.96.0 > Reporter: Jimmy Xiang > Assignee: Jimmy Xiang > Fix For: 0.96.0 > > Attachments: hbase-5719.patch > > > If there are too many regions in one overlapped group (by default, more than > 10), hbck currently doesn't merge them since it takes time. > In this case, we can sideline some regions in the group and break the > overlapping to fix the inconsistency. Later on, sidelined regions can be > bulk loaded manually. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira