belugabehr commented on a change in pull request #912: HBASE-23380: General
Cleanup of FSUtil
URL: https://github.com/apache/hbase/pull/912#discussion_r357275640
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java
##########
@@ -771,7 +770,7 @@ static public void addToHDFSBlocksDistribution(
public static int getTotalTableFragmentation(final HMaster master)
throws IOException {
Map<String, Integer> map = getTableFragmentation(master);
- return map != null && map.size() > 0 ? map.get("-TOTAL-") : -1;
Review comment:
That method says:
```
@return A map for each table and its percentage.
```
It does not say anything about returning a null value. I don't think it
needs to list everything it won't return. I think it's appropriate as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
