busbey edited a comment on issue #929: HBASE-23305: Remove dead code in AsyncRegistry URL: https://github.com/apache/hbase/pull/929#issuecomment-565459912 > Yes, I was planning to use the same jira ID for registry implementation. Just curious, why is there 1-1 commit-jira ID mapping? I thought it'd be good to group all the commits related to same jira grouped under a single jira ID. I'm breaking them up into smaller changes to make it easier for reviewers. Otherwise there is a lot of noise in the core PR that implements the functionality. that's fine, but then we should merge all of these into a feature branch and then get the feature branch into the main code base once they're all done. we aim for 1:1 commit:jira id to ensure that the work represented by a given jira is either in a release or not. If you want work broken up but still to point towards a larger goal, historically we've done that via an umbrella jira that then has subtasks. > @busbey Any thoughts on my last comment? Just to be clear, I don't mind creating a new jira and updating the PR with the ID. Just want to be sure I'm doing the right thing. Let me know how to proceed. In general you should expect turn around time on responses measured in 1-3 days from me, just fyi.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
