anoopsjohn commented on a change in pull request #939: HBASE-23349 : Force
archive compacted storefiles after current scanne…
URL: https://github.com/apache/hbase/pull/939#discussion_r357721085
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/ChangedReadersObserver.java
##########
@@ -40,5 +40,16 @@
* @param memStoreScanners scanner of current memstore
* @throws IOException e
*/
- void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner>
memStoreScanners) throws IOException;
+ void updateReaders(List<HStoreFile> sfs, List<KeyValueScanner>
memStoreScanners)
+ throws IOException;
+
+ /**
+ * Notify observers to close all scanners and re-create them from given list
of store files -
+ * should be non-compacted store files
+ *
+ * @param storeFiles non compacted store files to re-create scanners from
+ * @throws IOException if something goes wrong while dealing with store
scanners
+ */
+ void updateReaders(List<HStoreFile> storeFiles) throws IOException;
Review comment:
Why not pass the compacted away files and new files alone here? In the
above updateReaders method, the new flushed file(s) are only being passed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
