Apache9 commented on issue #941: HBASE-23326 Implement a ProcedureStore which 
stores procedures in a H…
URL: https://github.com/apache/hbase/pull/941#issuecomment-565817374
 
 
   And the most important thing to me is that, it could save us on depending on 
code which are not familiar with everyone in the community...
   
   The current procedure store implementation is super complicated(comparing to 
the problem it wants to solve). @allan163 and I have tried to make it more 
stable in the past and it seems that we could partly understand the 
implementation at that time. But after several months, I totally forgot what is 
going on here and need to learn it again...
   
   This is very dangerous, as procedure store is a very critical thing in 
HBase. So here I want to make it rely on the common read/write path code in 
HBase, which has been reviewed and will be reviewed by lots of committers in 
the community. Of course I still need to add some hacks to make it work but 
anyway, the hacky code are much easier to understand, comparing to the 
algorithm in BitSetNode and ProcedureStoreTracker...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to