Apache-HBase commented on issue #941: HBASE-23326 Implement a ProcedureStore 
which stores procedures in a H…
URL: https://github.com/apache/hbase/pull/941#issuecomment-565847130
 
 
   :broken_heart: **-1 overall**
   
   
   
   
   
   
   | Vote | Subsystem | Runtime | Comment |
   |:----:|----------:|--------:|:--------|
   | +0 :ok: |  reexec  |   0m 34s |  Docker mode activated.  |
   ||| _ Prechecks _ |
   | +1 :green_heart: |  dupname  |   0m  4s |  No case conflicting files 
found.  |
   | +1 :green_heart: |  hbaseanti  |   0m  0s |  Patch does not have any 
anti-patterns.  |
   | +1 :green_heart: |  @author  |   0m  0s |  The patch does not contain any 
@author tags.  |
   | +1 :green_heart: |  test4tests  |   0m  0s |  The patch appears to include 
65 new or modified test files.  |
   ||| _ master Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 45s |  Maven dependency ordering for branch  |
   | +1 :green_heart: |  mvninstall  |   5m 17s |  master passed  |
   | +1 :green_heart: |  compile  |   2m 59s |  master passed  |
   | +1 :green_heart: |  checkstyle  |   2m 41s |  master passed  |
   | +1 :green_heart: |  shadedjars  |   4m 37s |  branch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  javadoc  |   4m 35s |  master passed  |
   | +0 :ok: |  spotbugs  |   3m 47s |  Used deprecated FindBugs config; 
considering switching to SpotBugs.  |
   | +0 :ok: |  findbugs  |   0m 30s |  branch/hbase-assembly no findbugs 
output file (findbugsXml.xml)  |
   ||| _ Patch Compile Tests _ |
   | +0 :ok: |  mvndep  |   0m 22s |  Maven dependency ordering for patch  |
   | +1 :green_heart: |  mvninstall  |   4m 54s |  the patch passed  |
   | +1 :green_heart: |  compile  |   3m  1s |  the patch passed  |
   | +1 :green_heart: |  javac  |   3m  0s |  the patch passed  |
   | -1 :x: |  checkstyle  |   2m 44s |  root: The patch generated 7 new + 342 
unchanged - 4 fixed = 349 total (was 346)  |
   | -1 :x: |  whitespace  |   0m  0s |  The patch has 2 line(s) that end in 
whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer 
https://git-scm.com/docs/git-apply  |
   | +1 :green_heart: |  xml  |   0m  7s |  The patch has no ill-formed XML 
file.  |
   | +1 :green_heart: |  shadedjars  |   4m 31s |  patch has no errors when 
building our shaded downstream artifacts.  |
   | +1 :green_heart: |  hadoopcheck  |  15m 45s |  Patch does not cause any 
errors with Hadoop 2.8.5 2.9.2 or 3.1.2.  |
   | +1 :green_heart: |  javadoc  |   5m 11s |  the patch passed  |
   | -1 :x: |  findbugs  |   4m 56s |  hbase-server generated 2 new + 0 
unchanged - 0 fixed = 2 total (was 0)  |
   | +0 :ok: |  findbugs  |   0m 29s |  hbase-assembly has no data from 
findbugs  |
   | -1 :x: |  findbugs  |  14m 24s |  root generated 2 new + 0 unchanged - 0 
fixed = 2 total (was 0)  |
   ||| _ Other Tests _ |
   | +1 :green_heart: |  unit  | 262m 32s |  root in the patch passed.  |
   | +1 :green_heart: |  asflicense  |   3m  1s |  The patch does not generate 
ASF License warnings.  |
   |  |   | 375m  0s |   |
   
   
   | Reason | Tests |
   |-------:|:------|
   | FindBugs | module:hbase-server |
   |  |  Calling notifyAll rather than signalAll in 
org.apache.hadoop.hbase.procedure2.store.region.RegionFlusherAndCompactor.requestFlush()
  At RegionFlusherAndCompactor.java:in 
org.apache.hadoop.hbase.procedure2.store.region.RegionFlusherAndCompactor.requestFlush()
  At RegionFlusherAndCompactor.java:[line 204] |
   |  |  Possible null pointer dereference of files in 
org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(Map, 
CancelableProgressable, MonitoredTask)  Dereferenced at HRegion.java:files in 
org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(Map, 
CancelableProgressable, MonitoredTask)  Dereferenced at HRegion.java:[line 
4710] |
   | FindBugs | module:root |
   |  |  Calling notifyAll rather than signalAll in 
org.apache.hadoop.hbase.procedure2.store.region.RegionFlusherAndCompactor.requestFlush()
  At RegionFlusherAndCompactor.java:in 
org.apache.hadoop.hbase.procedure2.store.region.RegionFlusherAndCompactor.requestFlush()
  At RegionFlusherAndCompactor.java:[line 204] |
   |  |  Possible null pointer dereference of files in 
org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(Map, 
CancelableProgressable, MonitoredTask)  Dereferenced at HRegion.java:files in 
org.apache.hadoop.hbase.regionserver.HRegion.replayRecoveredEditsIfAny(Map, 
CancelableProgressable, MonitoredTask)  Dereferenced at HRegion.java:[line 
4710] |
   
   
   | Subsystem | Report/Notes |
   |----------:|:-------------|
   | Docker | Client=19.03.5 Server=19.03.5 base: 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/artifact/out/Dockerfile
 |
   | GITHUB PR | https://github.com/apache/hbase/pull/941 |
   | Optional Tests | dupname asflicense javac javadoc unit shadedjars 
hadoopcheck xml compile spotbugs findbugs hbaseanti checkstyle |
   | uname | Linux 5b348a0caea8 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 
16:55:30 UTC 2019 x86_64 GNU/Linux |
   | Build tool | maven |
   | Personality | 
/home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-941/out/precommit/personality/provided.sh
 |
   | git revision | master / de87d72bb4 |
   | Default Java | 1.8.0_181 |
   | checkstyle | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/artifact/out/diff-checkstyle-root.txt
 |
   | whitespace | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/artifact/out/whitespace-eol.txt
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/artifact/out/new-findbugs-hbase-server.html
 |
   | findbugs | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/artifact/out/new-findbugs-root.html
 |
   |  Test Results | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/testReport/
 |
   | Max. process+thread count | 5471 (vs. ulimit of 10000) |
   | modules | C: hbase-client hbase-server hbase-rsgroup hbase-assembly . U: . 
|
   | Console output | 
https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-941/1/console |
   | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 |
   | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org |
   
   
   This message was automatically generated.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to