[ 
https://issues.apache.org/jira/browse/HBASE-23326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997496#comment-16997496
 ] 

Michael Stack commented on HBASE-23326:
---------------------------------------

Thanks for putting up the doc. Can we have 'comment' access. Here are a few 
notes in meantime (some carried over from github comments):

On layout, could have a 'master' namespace so master Region is in same place in 
filesystem (Might be too awkward excluding this namespace from consideration in 
general processing).

Or, here you make a MasterProcs directory. Old system had a MasterProcWALs dir. 
Make instead a generic 'master' dir at top-level into which we put all stuff 
master wants to persist to filesystem of which these new procedures WALs would 
be first.

You cannot pass a RegionServerServices that has the special implementations of 
flush/compaction/rolling? Just to minimize how this Region implementation 
deviates from the norm.

WAL dirs will be deleted/cleanedup after WALs are moved to recovered.edits? 
There'll be no accumulation of WALs? What about archiving? Peter figured how to 
get the MasterProcWALs into the general WAL archive. Maybe no archiving of 
these WALs?

For recovered.edits, they content is supposed to be 'sorted'. When we move WALs 
to recovered.edits, they will be 'sorted' because we write in procedure order? 
Is there anything we need to do to ensure edits go into the WAL 'ordered'?

Nice writeup.







> Implement a ProcedureStore which stores procedures in a HRegion
> ---------------------------------------------------------------
>
>                 Key: HBASE-23326
>                 URL: https://issues.apache.org/jira/browse/HBASE-23326
>             Project: HBase
>          Issue Type: Improvement
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Major
>
> So we can resue the code in HRegion for persisting the procedures, and also 
> the optimized WAL implementation for better performance.
> This requires we merge the hbase-procedure module to hbase-server, which is 
> an anti-pattern as we make the hbase-server module more overloaded. But I 
> think later we can first try to move the WAL stuff out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to