virajjasani commented on a change in pull request #754: HBASE-22978 : Online
slow response log
URL: https://github.com/apache/hbase/pull/754#discussion_r358658512
##########
File path: hbase-common/src/main/resources/hbase-default.xml
##########
@@ -1930,4 +1930,15 @@ possible configurations would overwhelm and obscure the
important.
this feature.
</description>
</property>
+ <property>
+ <name>hbase.regionserver.slowlog.ringbuffer.size</name>
+ <value>256</value>
Review comment:
Rough estimation could be 400-800 KB (UTF-32) in total including all 256
entries, ideally we can increase the ringbuffer size, may be keep it to 1024
should be good?
However, if 256 is good enough to debug ongoing slow log responses, we can
keep as is? If client has quite robust configs, they can go with higher size
but ideally for default value, I feel 256 might be good to begin with. What is
your opinion?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
