busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r358602290
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -169,6 +230,24 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
long bytesWrittenProgressForCloseCheck = 0;
long bytesWrittenProgressForLog = 0;
long bytesWrittenProgressForShippedCall = 0;
+ // Clear old mob references
+ mobRefSet.get().clear();
+ boolean isUserRequest = userRequest.get();
+ boolean compactMOBs = major && isUserRequest;
+ boolean ioOptimizedMode =
+ conf.get(MobConstants.MOB_COMPACTION_TYPE_KEY,
MobConstants.DEFAULT_MOB_COMPACTION_TYPE)
+ .equals(MobConstants.IO_OPTIMIZED_MOB_COMPACTION_TYPE);
+
+ boolean discardMobMiss =
conf.getBoolean(MobConstants.MOB_UNSAFE_DISCARD_MISS_KEY,
+ MobConstants.DEFAULT_MOB_DISCARD_MISS);
+
+ long maxMobFileSize =
conf.getLong(MobConstants.MOB_COMPACTION_MAX_FILE_SIZE_KEY,
+ MobConstants.DEFAULT_MOB_COMPACTION_MAX_FILE_SIZE);
+ LOG.info("Compact MOB={} optimized={} maximum MOB file size={} major={}",
compactMOBs,
Review comment:
information about what we're compacting would be helpful here: table, cf,
region, something. I think we have a reference to the mobStore which should
have something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
