saintstack commented on a change in pull request #955: HBASE-23597 Give high
priority for meta assign procedure and ServerCr…
URL: https://github.com/apache/hbase/pull/955#discussion_r360443481
##########
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/AbstractProcedureScheduler.java
##########
@@ -174,7 +188,7 @@ public Procedure poll(final long nanos) {
return null;
}
}
- final Procedure pollResult = dequeue();
+ final Procedure pollResult = dequeue(highPriority);
pollCalls++;
nullPollCalls += (pollResult == null) ? 1 : 0;
Review comment:
How do we use this new functionality? We pass flag once set true for high
priority and then later false for all the rest?
IIRC, there is a mechanism for putting procedures at front of the queue
already... so we process children before their parent. We could not exploit
that mechanism here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
