[ 
https://issues.apache.org/jira/browse/HBASE-23604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17001294#comment-17001294
 ] 

Bharath Vissapragada commented on HBASE-23604:
----------------------------------------------

[~stack] That made sense to me. Infact when I read the code for the first time, 
I got confused too. I cleaned up the usage and added more javadocs. I also 
cleaned up the interface method names. Let me know what you think.  The patch 
is coming up shortly. (Given I'm touching these pieces of code, I decided to 
clean this up as well :-)).

> Usage of "registry" is unclear in the code.
> -------------------------------------------
>
>                 Key: HBASE-23604
>                 URL: https://issues.apache.org/jira/browse/HBASE-23604
>             Project: HBase
>          Issue Type: Task
>          Components: Client
>    Affects Versions: master
>            Reporter: Bharath Vissapragada
>            Assignee: Bharath Vissapragada
>            Priority: Minor
>
> As [~stack] noted in the code review 
> https://github.com/apache/hbase/pull/954, the usage of registry in the client 
> code is not super clear. The ask here is to rename it something that makes 
> the context more clear.
> Creating a separate jira because the patch touches a lots of files. I don't 
> want to mix it with the patch for HBASE-23305.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to