apurtell commented on a change in pull request #884: HBASE-23347 Allowable custom authentication methods for RPCs URL: https://github.com/apache/hbase/pull/884#discussion_r360611685
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/security/provider/SaslAuthenticationProvider.java ########## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.security.provider; + +import org.apache.hadoop.hbase.HBaseInterfaceAudience; +import org.apache.hadoop.io.Text; +import org.apache.yetus.audience.InterfaceAudience; +import org.apache.yetus.audience.InterfaceStability; + +/** + * Encapsulation of client-side logic to authenticate to HBase via some means over SASL. + * It is suggested that custom implementations extend the abstract class in the type hierarchy + * instead of directly implementing this interface (clients have a base class available, but + * servers presently do not). + * + * Implementations of this interface <b>must</b> be unique among each other via the {@code byte} + * returned by {@link SaslAuthMethod#getCode()} on {@link #getSaslAuthMethod()}. + */ [email protected](HBaseInterfaceAudience.AUTHENTICATION) [email protected] +public interface SaslAuthenticationProvider { Review comment: Consider a superinterface AuthenticationProvider and generic types for auth method and token kind? Then SaslAuthenticationProvider extends it and can provide SaslAuthMethod. See other comments regarding what I think is a naming nit. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
