saintstack commented on a change in pull request #941: HBASE-23326 Implement a 
ProcedureStore which stores procedures in a H…
URL: https://github.com/apache/hbase/pull/941#discussion_r361025552
 
 

 ##########
 File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/master/procedure/MasterProcedureUtil.java
 ##########
 @@ -146,16 +146,22 @@ public static long submitProcedure(final 
NonceProcedureRunnable runnable) throws
   /**
    * Pattern used to validate a Procedure WAL file name see
    * {@link #validateProcedureWALFilename(String)} for description.
+   * @deprecated Since 2.3.0, will be removed in 4.0.0. We do not use this 
style of procedure wal
+   *             file name any more.
    */
-  private static final Pattern pattern = Pattern.compile(".*pv2-\\d{20}.log");
+  @Deprecated
+  private static final Pattern PATTERN = Pattern.compile(".*pv2-\\d{20}.log");
+
+  // Use the character $ to let the log cleaner know that this is not the 
normal wal file.
+  public static final String ARCHIVED_PROC_WAL_SUFFIX = "$proc$";
 
 Review comment:
   Or s/proc/pv2/  or s/proc/masterproc/ so tied to your MasterProc dir?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to