saintstack commented on a change in pull request #958: HBASE-23584 : Descrease rpc getFileStatus count when open a storefile URL: https://github.com/apache/hbase/pull/958#discussion_r361072664
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileInfo.java ########## @@ -108,6 +109,7 @@ private RegionCoprocessorHost coprocessorHost; // timestamp on when the file was created, is 0 and ignored for reference or link files + // the before timestamp is shown as above ! Now i change to use the createdTimestamp of reference or link files , will it create some problem later ? Review comment: Where is 'above'. Comments don't usually refer to 'i' since code is product of many. What is the problem this will create and if you don't know what it might be, why change i? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
