binlijin commented on a change in pull request #960: HBASE-23613
ProcedureExecutor check StuckWorkers blocked by DeadServe…
URL: https://github.com/apache/hbase/pull/960#discussion_r361079543
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignmentManager.java
##########
@@ -1176,15 +1176,9 @@ protected void periodicExecute(final MasterProcedureEnv
env) {
if (rsn.getState() != State.OPEN) {
continue; // Opportunistic check, should quickly skip RITs, offline
tables, etc.
}
- ServerName sn;
- State state;
- rsn.lock();
- try {
- sn = rsn.getRegionLocation();
- state = rsn.getState();
- } finally {
- rsn.unlock();
- }
+ // Should not acquire region stat lock, this may block other important
work, see HBASE-23613.
+ ServerName sn = rsn.getRegionLocation();
+ State state = rsn.getState();
Review comment:
@Apache9 OK, change to it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
